Skip to content

Fix production WebSocket URL for web-cli #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emptyhammond merged 1 commit into from
Mar 6, 2026
+3 −1
Merged

Fix production WebSocket URL for web-cli #149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ on:
- 'pnpm-lock.yaml'
- 'tsconfig.json'
- 'scripts/**'
- 'examples/**'
- '.github/workflows/test.yml'
pull_request:
branches: [ main ]
Expand All @@ -20,6 +21,7 @@ on:
- 'pnpm-lock.yaml'
- 'tsconfig.json'
- 'scripts/**'
- 'examples/**'
- '.github/workflows/test.yml'

jobs:
Expand Down
2 changes: 1 addition & 1 deletion examples/web-cli/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ interface CliWindow extends Window {
}

// Default WebSocket URL - use public endpoint for production, localhost for development
const DEFAULT_PRODUCTION_WEBSOCKET_URL = "wss://web-cli.ably.com";
const DEFAULT_PRODUCTION_WEBSOCKET_URL = "wss://web-cli-terminal.ably.com";
const DEFAULT_DEVELOPMENT_WEBSOCKET_URL = "wss://web-cli-terminal.ably-dev.com";

// Get WebSocket URL from query parameters only
Expand Down
Loading