CRT Strip Hit Saturation

[henrylay97]

I am starting to put together slides and PRs to preserve work of mine that lives offline before I leave.

The saturation parameters in the CRTStripHit object were being filled via a hardcoded value in the constructor. This PR ensures they can be controlled a little more subtly by passing that value in the constructor fields. This constructor will not be directly used as the accompanying PR makes use of the other constructor (fully explicit) but this is still worth changing to remove the hardcoded element.

It is documented in slides: https://sbn-docdb.fnal.gov/cgi-bin/sso/ShowDocument?docid=45697
Accompanying PR: SBNSoftware/sbndcode#917

[leoaliaga]

trigger build SBNSoftware/sbndcode#917

[leoaliaga]

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_15_00 SBNSoftware/sbncode@v10_15_00 SBNSoftware/sbndcode#917

[leoaliaga]

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_15_00 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbn*@SBN_SUITE_v10_15_00 SBNSoftware/sbndcode#917

[leoaliaga]

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_15_00 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbndcode#917

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

[FNALbuild]

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

[FNALbuild]

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

[FNALbuild]

❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

[FNALbuild]

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

[leoaliaga]

This PR modifies the CRTStripHit data product. Please bump the ClassVersion for sbnd::crt::CRTStripHit from 12 to 13 and push the commit.

[henrylay97]

I am getting no prompt from the compiler to update the checksum (true while I was developing and have just rechecked now). This has always been my previous method when editing object files.

Do checksums definitely need updating if the data members have not changed?

[henrylay97]

I double checked by adding class version 13 and it produces an identical checksum to class version 12.

[leoaliaga]

Henry, you are right. I think since you only modified the constructor, the checksum remain identical. I suspected a problem here because it did not pass the CI test but the problem is different (nothing with this PR)