Conversation
sbnobj/SBND/CRT/CRTBlob.cxx
Outdated
| namespace crt { | ||
|
|
||
| CRTBlob::CRTBlob() | ||
| : fTs0 (0.) |
There was a problem hiding this comment.
Maybe these should be initialized to non-physical values for debugging? I guess zero PE is sufficient to flag the blob as uninteresting. Other than this, the class looks good and I approve of the changes
There was a problem hiding this comment.
This is just a suggestion but I think it's probably ok to leave things in the current state
There was a problem hiding this comment.
No no this is a very sensible point, thanks Alex! I'll implement now.
aantonakis
left a comment
aantonakis
left a comment
There was a problem hiding this comment.
Hi Henry, the class looks good and I approve merging the changes. It just needs to be updated to the latest branch. I left a comment about the default values but I think they are sufficient for analysis.
|
Great comment from @aantonakis . I noticed it was a theme across SBND CRT objects. Whilst there is no scenario in the producer modules that should ever use the default constructor it still seemed worth changing the default values to more obviously non-physical values across the board. |
|
trigger build LArSoft/lar*@LARSOFT_SUITE_v10_15_00 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbndcode#916 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for e26:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs parent CI build details are available through the CI dashboard |
4 participants
I am starting to put together slides and PRs to preserve work of mine that lives offline before I leave.
The CRTBlob reconstruction aims to produce objects that represent the totality of all activity happening within a fcl-configurable coincidence window. They are similar to CRTTracks but without geometric track constraints, and as such can capture all activity from a single source, for example when multiple particles from the same air shower are detected or secondary particles are produced from the muon scattering.
It was used to produce a plot for the detector paper and is therefore worth preserving. It is not run by default in production fcls but does provide fcls for running it independently in the CRT-only workflow or standalone. Nothing prevents it being added to production fcls in future if it is desired for any analyses.
It is documented in slides: https://sbn-docdb.fnal.gov/cgi-bin/sso/ShowDocument?docid=45658
Accompanying PR: SBNSoftware/sbndcode#916