Skip to content

Updates for first reprocessing of PDS products in spring productions#876

Open
mvicenzi wants to merge 78 commits intorelease/SBN2025Afrom
feature/mvicenzi_repro_step1
Open

Updates for first reprocessing of PDS products in spring productions#876
mvicenzi wants to merge 78 commits intorelease/SBN2025Afrom
feature/mvicenzi_repro_step1

Conversation

@mvicenzi
Copy link
Member

@mvicenzi mvicenzi commented Dec 8, 2025

This PR contains the required updates and fhicls to enable the first reprocessing of light products for the SBN2025 spring productions (both MC and data). In particular, the following changes are implemented:

  • MC2 tune (SPR + sim gain tune)
  • MC3/4 tune (SPR + sim gain tune)
  • Simulation of timing delays from database in overlays
  • Noise in MC waveform turned off for overlays
  • Overlay waveform chopping
  • DetSim + Overlay stage reprocessing fhicl(s)
  • Reco gain tune for run2/3/4
  • SPEArea database for optical reconstruction in data/overlays
  • OpHit recalibrator module for data
  • formally same reconstruction algorithms for data and MC (including pedestal's)
  • “MCStage0” reprocessing fhicl(s)
  • Data “stage0” reprocessing fhicl(s)

This PR depends on:

mvicenzi and others added 30 commits May 23, 2025 00:17
…plate

It used to end when the template SPR goes under 1e-4 ADC#.
Now it needs to stay within +/- 1w-4 ADC# for 20 nanoseconds.
This should make it possible to include undershootings.
All these parameters are currently hard-coded.
Good catches on names and strings.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Trigger simulation modules now support input tags with process name [private]
@mvicenzi mvicenzi removed the request for review from gputnam January 19, 2026 23:05
@mvicenzi mvicenzi force-pushed the feature/mvicenzi_repro_step1 branch from fdd76d8 to 419088b Compare January 19, 2026 23:45
@mvicenzi mvicenzi force-pushed the feature/mvicenzi_repro_step1 branch from 419088b to c435bf2 Compare January 20, 2026 00:01
@mvicenzi mvicenzi marked this pull request as ready for review January 20, 2026 00:16
Copy link
Member

@PetrilloAtWork PetrilloAtWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not find anything positively wrong.
However, I feel this is set up to add the n+1 layer of nightmare to configuration maintainers: with the fact that we discussed the workflow patterns many times together, and having laid out in front of me all the changes, I still had very hard time understanding the meaning of many of the choices, and their reasons. This may be mitigated by generously adding inline explanations or, if available, references to external documentation (like clear DocDB presentations). Especially useful would be to add a general introduction to many of the job configurations, to help people do fewer mistakes when they copy those into new ones for different data periods or samples.
I leave this unapproved (not disapproved either) for the first round. We (you and the release managers, mostly) may decide on the priorities of the changes suggested in this review with the merge of as-is material.

(Oh, there is actually one explicit request of changing the name of speAreas.fcl)

@mvicenzi
Copy link
Member Author

mvicenzi commented Mar 5, 2026

@PetrilloAtWork Thank you for your detailed review, as always!

I've reviewed and processed all your comments, taking the initiative of marking as resolved those that I accepted or that did not require further discussions. I left open a few ones where you might want to take a look at my answer.

I share your nightmarish visions: this is absoutely becoming a nightmare to mantain. There are dozen of variants, plus the need to support two MC flows (legacy + overlays) and multiple run periods (hence, different tunes).
I'd say the situation will eventually improve a little once the PMT detsim module is updated to pick gain and SPR from their respective databases: that would get rid of the need of supporting multiple overlays fhicls (but still not for the legacy MC!).

I've tried to add some introductory explanations to all the optical post-processing fhicls, but the general detsim crazyness is beyond my powers and also beyond the scope of this PR.

Unfortunately, there is no DocDB presentation detailing all the choices... reviwing everything a second time has just drained my life forces but once I muster back some strength I'll see what I can do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants