Updates for first reprocessing of PDS products in spring productions#876
Updates for first reprocessing of PDS products in spring productions#876mvicenzi wants to merge 78 commits intorelease/SBN2025Afrom
Conversation
…plate It used to end when the template SPR goes under 1e-4 ADC#. Now it needs to stay within +/- 1w-4 ADC# for 20 nanoseconds. This should make it possible to include undershootings. All these parameters are currently hard-coded.
…icles that might cross cathode
Good catches on names and strings. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Trigger simulation modules now support input tags with process name [private]
Also fixed a preexisting issue with (obsolete) FHiCL job configurations.
fdd76d8 to
419088b
Compare
419088b to
c435bf2
Compare
PetrilloAtWork
left a comment
There was a problem hiding this comment.
I could not find anything positively wrong.
However, I feel this is set up to add the n+1 layer of nightmare to configuration maintainers: with the fact that we discussed the workflow patterns many times together, and having laid out in front of me all the changes, I still had very hard time understanding the meaning of many of the choices, and their reasons. This may be mitigated by generously adding inline explanations or, if available, references to external documentation (like clear DocDB presentations). Especially useful would be to add a general introduction to many of the job configurations, to help people do fewer mistakes when they copy those into new ones for different data periods or samples.
I leave this unapproved (not disapproved either) for the first round. We (you and the release managers, mostly) may decide on the priorities of the changes suggested in this review with the merge of as-is material.
(Oh, there is actually one explicit request of changing the name of speAreas.fcl)
icaruscode/Generators/SelectCathodeCrossingGenParticles_module.cc
Outdated
Show resolved
Hide resolved
fcl/detsim/partial/detsim_opdetonly_icarus_overlay_reprocessing_run2.fcl
Show resolved
Hide resolved
Co-authored-by: Gianluca Petrillo <petrillo@slac.stanford.edu>
|
@PetrilloAtWork Thank you for your detailed review, as always! I've reviewed and processed all your comments, taking the initiative of marking as resolved those that I accepted or that did not require further discussions. I left open a few ones where you might want to take a look at my answer. I share your nightmarish visions: this is absoutely becoming a nightmare to mantain. There are dozen of variants, plus the need to support two MC flows (legacy + overlays) and multiple run periods (hence, different tunes). I've tried to add some introductory explanations to all the optical post-processing fhicls, but the general detsim crazyness is beyond my powers and also beyond the scope of this PR. Unfortunately, there is no DocDB presentation detailing all the choices... reviwing everything a second time has just drained my life forces but once I muster back some strength I'll see what I can do. |
This PR contains the required updates and fhicls to enable the first reprocessing of light products for the SBN2025 spring productions (both MC and data). In particular, the following changes are implemented:
This PR depends on:
icarus_dataupdate with new SPR responses + new SPRArea database