[18.0][FIX] queue_job: Fix TestJson

[Andrii9090-tecnativa]

When a module adds a value in context, the tests fail.

For example:

  File "/opt/odoo/auto/addons/queue_job/tests/test_json_field.py", line 33, in test_encoder_recordset
    self.assertEqual(json.loads(value_json), expected)
AssertionError: {'_type': 'odoo_recordset', 'model': 'res.p[93 chars]ls'}} != {'uid': 6, '_type': 'odoo_recordset', 'mode[178 chars]ls'}}
  {'_type': 'odoo_recordset',
-  'context': {'lang': 'en_US', 'tz': 'Europe/Brussels'},
+  'context': {'lang': 'en_US',
+              'map_website_id': False,
+              'route_map_website_id': False,
+              'route_start_partner_id': 2,
+              'tz': 'Europe/Brussels'},
   'ids': [1],
   'model': 'res.partner',
   'su': False,
   'uid': 6}

  File "/opt/odoo/auto/addons/queue_job/tests/test_json_field.py", line 55, in test_encoder_recordset_list
    self.assertEqual(json.loads(value_json), expected)
AssertionError: Lists differ: ['a', 1, {'_type': 'odoo_recordset', 'model': 'res.p[94 chars]s'}}] != ['a', 1, {'uid': 6, '_type': 'odoo_recordset', 'mode[179 chars]s'}}]
First differing element 2:
{'_type': 'odoo_recordset', 'model': 'res.p[93 chars]ls'}}
{'uid': 6, '_type': 'odoo_recordset', 'mode[178 chars]ls'}}
  ['a',
   1,
   {'_type': 'odoo_recordset',
-   'context': {'lang': 'en_US', 'tz': 'Europe/Brussels'},
+   'context': {'lang': 'en_US',
+               'map_website_id': False,
+               'route_map_website_id': False,
+               'route_start_partner_id': 2,
+               'tz': 'Europe/Brussels'},
    'ids': [1],
    'model': 'res.partner',
    'su': False,
    'uid': 6}]

In this example, the partner_external_map module added map_website_id, route_map_website_id, and route_start_partner_id to the context, which caused the tests of queue_job to fail.

This fix ensures that only the keys returned by _job_prepare_context_before_enqueue_keys are preserved in the context, removing any additional values.

@pedrobaeza @christian-ramos-tecnativa could you review this PR?

[amh-mw]

Code review only, LGTM.

[pedrobaeza]

I don't think this is the proper fix, but to control the context in the tests for not having that one, but you may want to have all the context keys serialized for any usage of it.

[Andrii9090-tecnativa]

@pedrobaeza How can this be done, by modifying the _job_prepare_context_before_enqueue_keys method?

[pedrobaeza]

Seeing the module, I think the final test line should be changed from:

self.assertEqual(json.loads(value_json), expected)

to:

result_dict = json.loads(value_json)
for key in result_dict:
    self.assertEqual(result_dict[key], expected[key])

[christian-ramos-tecnativa]

You could compare the jsons without the context and then loop through it as @pedrobaeza suggested

[christian-ramos-tecnativa]

I think is not fully solved as we should loop just for the context key

[christian-ramos-tecnativa]

I was able to solve it with this changes

[christian-ramos-tecnativa]

LGTM!

[pedrobaeza]

OK, let's make it resilient this way.

/ocabot merge patch

[OCA-git-bot]

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-909-by-pedrobaeza-bump-patch, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 1ea2c45. Thanks a lot for contributing to OCA. ❤️