fix(acceptor): upgrade sspi, use NTLM when no Kerberos#1143
fix(acceptor): upgrade sspi, use NTLM when no Kerberos#1143Guillaume Gelin (ramnes) wants to merge 1 commit intoDevolutions:masterfrom
Conversation
4b888db to
8d3008a
Compare
Upgrade sspi to incorporate latest changes. The new version introduces a real SPNEGO implementation in `ServerMode::Negotiate`, but some RDP clients seem to send raw NTLM tokens in CredSSP rather than SPNEGO-wrapped ones, which doesn't seem supported by sspi yet? In the meantime, we can use `ServerMode::Ntlm` directly when Kerberos is disabled, so that we maintain compatibility with previous sspi behavior.
8d3008a to
2357866
Compare
|
Hi, yes, you are right. Let me add more context for others and for historical reasons 🙃
Yep.
It is supported, but the user (the caller) must specify it explicitly via
Currently, that's the only way to do so. |
Upgrade sspi to incorporate latest changes. The new version introduces a real SPNEGO implementation in
ServerMode::Negotiate, but some RDP clients seem to send raw NTLM tokens in CredSSP rather than SPNEGO-wrapped ones, which doesn't seem supported by sspi yet? In the meantime, we can useServerMode::Ntlmdirectly when Kerberos is disabled, so that we maintain compatibility with previous sspi behavior.Note: I can't get the dependencies right, looks like there's a picky rc.22 / getrandom conflict; any help appreciated here!