Skip to content

initial changes to replace the nanorc name with a more generic 'dunerc' name#147

Open
bieryAtFnal wants to merge 2 commits intodevelopfrom
kbiery/nanorc_to_dunerc_name_change
Open

initial changes to replace the nanorc name with a more generic 'dunerc' name#147
bieryAtFnal wants to merge 2 commits intodevelopfrom
kbiery/nanorc_to_dunerc_name_change

Conversation

@bieryAtFnal
Copy link
Contributor

Description

As requested in #129 , we would like to replace occurrences of the name "nanorc" with something more generic in our integration tests.

The changes in this PR are a first step in doing that. These changes replace "nanorc" with "dunerc" in the integrationtest infrastructure. "dunerc" (i.e. "DUNE Run Control") is our current choice for the new name, rather than "drunc", so that it is more generic than the name of the current run control application.

These changes were made in a backward-compatible way. This means that they can be used by the existing integtests in the various repos. The backward-compatibility was implemented by keeping a few occurrences of the nanorc name around. We will be able to remove those once all integtests are converted.

Here are suggested instructions for testing these changes. They demonstrate the successful running of these changes in one integtest that has been converted from "nanorc" to "dunerc" and several that haven't been converted.

DATE_PREFIX=`date '+%d%b'`
TIME_SUFFIX=`date '+%H%M'`

source /cvmfs/dunedaq.opensciencegrid.org/setup_dunedaq.sh
setup_dbt latest
dbt-create -n NFD_DEV_260303_A9 ${DATE_PREFIX}FDDevTest_${TIME_SUFFIX}
cd ${DATE_PREFIX}FDDevTest_${TIME_SUFFIX}/sourcecode

git clone http://github.com/DUNE-DAQ/daqsystemtest.git -b develop
git clone http://github.com/DUNE-DAQ/listrev.git -b kbiery/nanorc_to_dunerc_name_change
cd ..

cd pythoncode
git clone http://github.com/DUNE-DAQ/integrationtest.git -b kbiery/nanorc_to_dunerc_name_change
cd ..

dbt-workarea-env
dbt-build -j 12
dbt-workarea-env

dunedaq_integtest_bundle.sh -r 'daqsystemtest|dfmodules|listrev' -k 'min|tpstream|offline|listrev' --concise

echo ""
echo -e "\U1F535 \U2705 Note that a selection of integtests passed. \U2705 \U1F535"
echo ""
echo ""

Type of change

  • Optimization (non-breaking change that improves code/performance)

Testing checklist

  • Full set of integration tests pass (dunedaq_integtest_bundle.sh)

Further checks

  • Code is commented where needed, particularly in hard-to-understand areas

@bieryAtFnal
Copy link
Contributor Author

I should have mentioned that there are kbiery/nanorc_to_dunerc_name_change branches in daqsystemtest, dfmodules, and listrev, these branches have the necessary changes to replace "nanorc" with "dunerc", and I'd like to consider this PR separately from them in order to give us flexibility in when the repo-based integtests get merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Medium Impact Change]: Update references to nanorc in our integrationtests to drunc or a more generic name

1 participant