initial changes to replace the nanorc name with a more generic 'dunerc' name#147
Open
bieryAtFnal wants to merge 2 commits intodevelopfrom
Open
initial changes to replace the nanorc name with a more generic 'dunerc' name#147bieryAtFnal wants to merge 2 commits intodevelopfrom
bieryAtFnal wants to merge 2 commits intodevelopfrom
Conversation
Contributor
Author
|
I should have mentioned that there are |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As requested in #129 , we would like to replace occurrences of the name "nanorc" with something more generic in our integration tests.
The changes in this PR are a first step in doing that. These changes replace "nanorc" with "dunerc" in the
integrationtestinfrastructure. "dunerc" (i.e. "DUNE Run Control") is our current choice for the new name, rather than "drunc", so that it is more generic than the name of the current run control application.These changes were made in a backward-compatible way. This means that they can be used by the existing integtests in the various repos. The backward-compatibility was implemented by keeping a few occurrences of the
nanorcname around. We will be able to remove those once all integtests are converted.Here are suggested instructions for testing these changes. They demonstrate the successful running of these changes in one integtest that has been converted from "nanorc" to "dunerc" and several that haven't been converted.
Type of change
Testing checklist
dunedaq_integtest_bundle.sh)Further checks