Skip to content

[Common] Use helix propagation to compute fwdtrack DCA in fwdtrackextension#14282

Merged
dsekihat merged 6 commits intoAliceO2Group:masterfrom
mcoquet642:fwddca-helix
Mar 2, 2026
Merged

[Common] Use helix propagation to compute fwdtrack DCA in fwdtrackextension#14282
dsekihat merged 6 commits intoAliceO2Group:masterfrom
mcoquet642:fwddca-helix

Conversation

@mcoquet642
Copy link
Collaborator

No description provided.

@github-actions
Copy link

github-actions bot commented Dec 18, 2025

O2 linter results: ❌ 2 errors, ⚠️ 1 warnings, 🔕 0 disabled

@alibuild
Copy link
Collaborator

alibuild commented Jan 10, 2026

Error while checking build/O2Physics/o2 for 81fb988 at 2026-02-21 17:29:

No log files found

Full log here.

@mcoquet642
Copy link
Collaborator Author

Hi @jgrosseo @ddobrigk @iarsene, if this looks ok to you, could this be merged ?

@vkucera
Copy link
Collaborator

vkucera commented Feb 24, 2026

@ddobrigk @iarsene @dsekihat This PR has been opened for review for 2 months without a review.

@dsekihat dsekihat merged commit 2c27f23 into AliceO2Group:master Mar 2, 2026
13 of 14 checks passed

Service<o2::ccdb::BasicCCDBManager> fCCDB;
o2::parameters::GRPMagField* grpmag = nullptr; // for run 3, we access GRPMagField from GLO/Config/GRPMagField
int fCurrentRun; // needed to detect if the run changed and trigger update of magnetic field
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uninitialised

SMatrix5 tpars(mfttrack.x(), mfttrack.y(), mfttrack.phi(), mfttrack.tgl(), mfttrack.signed1Pt());
SMatrix55 tcovs{};
o2::track::TrackParCovFwd mft{mfttrack.z(), tpars, tcovs, mfttrack.chi2()};
fwdtrack = o2::aod::fwdtrackutils::refitGlobalMuonCov(propmuon, mft);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slicing object from type GlobalFwdTrack to TrackParCovFwd discards 40 bytes of state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants