Skip to content

[O2B-1534] Migrate log overview to use filtering model pattern#2083

Open
NarrowsProjects wants to merge 34 commits intomainfrom
improv/O2B-1534/Migrate-Log-Overview-to-use-FilteringModel-pattern
Open

[O2B-1534] Migrate log overview to use filtering model pattern#2083
NarrowsProjects wants to merge 34 commits intomainfrom
improv/O2B-1534/Migrate-Log-Overview-to-use-FilteringModel-pattern

Conversation

@NarrowsProjects
Copy link
Collaborator

@NarrowsProjects NarrowsProjects commented Feb 20, 2026

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • Individual from-to selectors on the logs page have been replaced with a single field that will open the standard time range selector
  • All open-input forms apply their filters when focus is lost on them.

Notable changes for developers:

  • All filters have been moved to a filteringModel in logsOverviewModel
  • The filters for runs, lhcfills and environments have been renamed under the hood to match getAllRunsUseCase:
    • runs => runNumbers
    • lhcFills => fillNumbers
    • environments => environmentIds

Changes made to the database:

  • none

@NarrowsProjects NarrowsProjects self-assigned this Feb 20, 2026
@NarrowsProjects NarrowsProjects added frontend javascript Pull requests that update Javascript code labels Feb 20, 2026
@NarrowsProjects NarrowsProjects marked this pull request as draft February 20, 2026 11:53
@codecov
Copy link

codecov bot commented Feb 20, 2026

Codecov Report

❌ Patch coverage is 39.02439% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.84%. Comparing base (ecbbda0) to head (0d8d3d4).

Files with missing lines Patch % Lines
...ib/public/views/Logs/Overview/LogsOverviewModel.js 0.00% 11 Missing ⚠️
...blic/views/Logs/ActiveColumns/logsActiveColumns.js 0.00% 7 Missing ⚠️
...nts/Filters/LogsFilter/author/AuthorFilterModel.js 0.00% 3 Missing ⚠️
...mponents/Filters/LogsFilter/author/authorFilter.js 0.00% 2 Missing ⚠️
...ic/components/Filters/common/filters/textFilter.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2083      +/-   ##
==========================================
+ Coverage   45.58%   45.84%   +0.25%     
==========================================
  Files        1040     1038       -2     
  Lines       17310    17165     -145     
  Branches     3134     3103      -31     
==========================================
- Hits         7891     7869      -22     
+ Misses       9419     9296     -123     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@NarrowsProjects NarrowsProjects force-pushed the improv/O2B-1534/Migrate-Log-Overview-to-use-FilteringModel-pattern branch from 07567e2 to 114285d Compare February 20, 2026 12:02
@NarrowsProjects NarrowsProjects force-pushed the improv/O2B-1534/Migrate-Log-Overview-to-use-FilteringModel-pattern branch from a936a03 to 5500b3e Compare February 20, 2026 16:24
@NarrowsProjects NarrowsProjects marked this pull request as ready for review February 21, 2026 18:22
@NarrowsProjects NarrowsProjects marked this pull request as draft March 5, 2026 11:57
@NarrowsProjects NarrowsProjects marked this pull request as ready for review March 5, 2026 12:05
NarrowsProjects and others added 8 commits March 5, 2026 15:34
* Filtering by stableBeamsStart and stableBeamsEnd has been added to LHC Fills overview page
* lhcFills endpoint & DTO validation modified and testing added for the aforementioned changes
---------

Co-authored-by: GuustMetz <guust.metz@cern.ch>
Co-authored-by: Guust <metzguust@gmail.com>
* Replaced the two-query pattern with a single queryBuilder in GetAllEnvironmentsUseCase. The previous approach was redundant following Sequelize performance improvements; furthermore, the original implementation's logic was flawed which resulted in the pagination bug.
@NarrowsProjects NarrowsProjects force-pushed the improv/O2B-1534/Migrate-Log-Overview-to-use-FilteringModel-pattern branch from 6e3b780 to ada3eb3 Compare March 5, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend javascript Pull requests that update Javascript code

Development

Successfully merging this pull request may close these issues.

2 participants